fix: allOf cycle detection oversight#2316
Merged
mromaszewicz merged 1 commit intooapi-codegen:mainfrom Apr 11, 2026
Merged
Conversation
PR oapi-codegen#1377 was merged too early. This is a small follow-up tweak to make sure that oapi-codegen#1373 is fixed properly. seed allOf[0] ref into cycle detection to prevent stack overflow when self-ref is first When the self-referencing $ref appears at position 0 in allOf, its ref was never added to seenSchemaRef. If s1's own AllOf contained a back-reference to itself, mergeAllOf would not detect the cycle. Seed allOf[0].Ref into a top-level seen set that is copied into each iteration's seenSchemaRef map, closing this gap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jamietanna
approved these changes
Apr 11, 2026
Member
jamietanna
left a comment
There was a problem hiding this comment.
Seems reasonable, but if we're able to get a test (or a spec) to validate the change works as expectedly that'd be ideal!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1377 was merged too early. This is a small follow-up tweak to make sure that #1373 is fixed properly.
seed allOf[0] ref into cycle detection to prevent stack overflow when self-ref is first
When the self-referencing $ref appears at position 0 in allOf, its ref was never added to seenSchemaRef. If s1's own AllOf contained a back-reference to itself, mergeAllOf would not detect the cycle.
Seed allOf[0].Ref into a top-level seen set that is copied into each iteration's seenSchemaRef map, closing this gap.