Skip to content

Constrain Renovate to Go 1.24#2314

Open
mromaszewicz wants to merge 3 commits intooapi-codegen:mainfrom
mromaszewicz:chore/renovate
Open

Constrain Renovate to Go 1.24#2314
mromaszewicz wants to merge 3 commits intooapi-codegen:mainfrom
mromaszewicz:chore/renovate

Conversation

@mromaszewicz
Copy link
Copy Markdown
Member

Renovate keeps suggesting dependency updates which bump our pinned Go version. This should constrain it to the 1.24 toolchain. This constraint needs to be set to match the Go version in our top level go.mod

Renovate keeps suggesting dependency updates which bump our pinned Go
version. This should constrain it to the 1.24 toolchain. This constraint
needs to be set to match the Go version in our top level go.mod
@mromaszewicz mromaszewicz requested a review from a team as a code owner April 3, 2026 18:13
@mromaszewicz mromaszewicz added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Apr 3, 2026
Copy link
Copy Markdown
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably also want to make sure that GOTOOLCHAIN=local via env, otherwise we'll automagically pull the new toolchain on updates - we'd probably prefer a PR to fail its creation if it's trying to use a newer version?

@mromaszewicz
Copy link
Copy Markdown
Member Author

We'll probably also want to make sure that GOTOOLCHAIN=local via env, otherwise we'll automagically pull the new toolchain on updates - we'd probably prefer a PR to fail its creation if it's trying to use a newer version?

We already have the toolchain pinned in go.mod, and I think this might cause problems, because the local toolchain, just hypothetically, might be 1.24.3 and this will cause a failure.

@jamietanna
Copy link
Copy Markdown
Member

Discussing in renovatebot/renovate#42459

@jamietanna
Copy link
Copy Markdown
Member

because the local toolchain, just hypothetically, might be 1.24.3 and this will cause a failure.

The failure (IMO) would be preferable, as it'd make sure that it wasn't updating the go directive

(That being said, I think Renovate still raises a PR if branch creation fails)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants