Skip to content

WIP: Issue 2091 #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jamietanna wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Issue 2091 #2092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8106aef
Co-authored-by: gpt-4.1 <github-copilot@jamietanna.co.uk>
jamietanna Sep 23, 2025
62f3801
sq
jamietanna Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/test/issues/issue2091/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# yaml-language-server: $schema=../../../../configuration-schema.json
package: issue2091
generate:
models: true
output: issue2091.gen.go
output-options:
skip-prune: true
28 changes: 28 additions & 0 deletions internal/test/issues/issue2091/gen_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package issue2091

import (
"reflect"
"slices"
"strings"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

// via gpt-4.1 (GitHub Copilot)
func hasOmitEmptyTag(field reflect.StructField) bool {
tag := field.Tag.Get("json")
parts := strings.Split(tag, ",")
return slices.Contains(parts[1:], "omitempty")
}

// via gpt-4.1 (GitHub Copilot)
func TestTypeWithNullableHasOmitEmpty(t *testing.T) {
typ := reflect.TypeOf(TypeWithNullable{})

field, ok := typ.FieldByName("Name")
require.True(t, ok)

assert.True(t, hasOmitEmptyTag(field), "newfield should have `omitempty` set, given the usage of `nullable: true`")
}
3 changes: 3 additions & 0 deletions internal/test/issues/issue2091/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package issue2091

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml openapi.yaml
9 changes: 9 additions & 0 deletions internal/test/issues/issue2091/issu2091.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions internal/test/issues/issue2091/issue2091.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions internal/test/issues/issue2091/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
openapi: "3.0.0"
info:
version: 1.0.0
title: "Specifying `nullable: true` should imply `omitempty`"
components:
schemas:
TypeWithNullable:
type: object
properties:
newfield:
type: string
nullable: true
Loading