Bug Report: demonstration of overlays and allOf not playing together nicely#2087
Open
nelzblooket wants to merge 1 commit intooapi-codegen:mainfrom
Open
Bug Report: demonstration of overlays and allOf not playing together nicely#2087nelzblooket wants to merge 1 commit intooapi-codegen:mainfrom
nelzblooket wants to merge 1 commit intooapi-codegen:mainfrom
Conversation
Kusari Analysis Results:
No pinned version dependency changes, code issues or exposed secrets detected! Note View full detailed analysis result for more information on the output and the checks that were run.
Found this helpful? Give it a 👍 or 👎 reaction! |
nelzblooket
commented
Sep 12, 2025
| Id int `json:"id"` | ||
| Name string `json:"name"` | ||
| } | ||
| type ClientWithId = OverlayClient |
Author
There was a problem hiding this comment.
I would expect this to be OverlayClientWithId
Suggested change
| type ClientWithId = OverlayClient | |
| type ClientWithId = OverlayClientWithId |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the instructions:
Version of
oapi-codegen- frommainpulled today:Go version:
Problem statement:
When doing an overlay of a type that has an
allOfwith a reference to another overlay, the subset overlay is being created as the alias in the generated file.