Kusari Analysis Results

Analysis for commit: b690045, performed at: 2025-08-02T11:55:19Z

• @kusari-inspector rerun - Trigger a re-analysis of this PR

• @kusari-inspector feedback [your message] - Send feedback to our AI and team

Recommendation

✅ PROCEED with this Pull Request

Summary

✅ No Flagged Issues Detected

All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Found this helpful? Give it a 👍 or 👎 reaction!

Kusari PR Analysis rerun based on - ea62ed3 performed at: 2025-08-02T05:09:15Z - link to updated analysis

Kusari PR Analysis rerun based on - fab1963 performed at: 2025-08-02T05:11:59Z - link to updated analysis

Kusari PR Analysis rerun based on - a3cd398 performed at: 2025-08-02T06:16:38Z - link to updated analysis

Kusari PR Analysis rerun based on - 1511442 performed at: 2025-08-02T07:22:05Z - link to updated analysis

Thanks, will try and review at some point. Is it worth committing the benchmark code for future testing?

Kusari PR Analysis rerun based on - 3acf76d performed at: 2025-08-02T11:53:02Z - link to updated analysis

Thanks, will try and review at some point. Is it worth committing the benchmark code for future testing?

I added a commit with a benchmark test

Kusari PR Analysis rerun based on - b690045 performed at: 2025-08-02T11:55:19Z - link to updated analysis

Thanks. From what I can see:

Before:

% cd ./pkg/codegen
% go test ./ -bench=.
goos: linux
goarch: amd64
pkg: github.com/oapi-codegen/oapi-codegen/v2/pkg/codegen
cpu: 12th Gen Intel(R) Core(TM) i7-12800H
Benchmark_concatPath1param-20           131724429               10.39 ns/op            0 B/op          0 allocs/op
Benchmark_concatPath2param-20           25299087                44.80 ns/op           48 B/op          1 allocs/op
PASS
ok      github.com/oapi-codegen/oapi-codegen/v2/pkg/codegen     3.672s
go test ./ -bench=.  5.07s user 0.64s system 141% cpu 4.032 total

After:

% cd ./pkg/codegen
% go test ./ -bench=.
goos: linux
goarch: amd64
pkg: github.com/oapi-codegen/oapi-codegen/v2/pkg/codegen
cpu: 12th Gen Intel(R) Core(TM) i7-12800H
Benchmark_concatPath1param-20           130095781                8.806 ns/op           0 B/op          0 allocs/op
Benchmark_concatPath2param-20           34524310                37.85 ns/op           48 B/op          1 allocs/op
PASS
ok      github.com/oapi-codegen/oapi-codegen/v2/pkg/codegen     3.674s
go test ./ -bench=.  4.89s user 0.53s system 135% cpu 3.994 total

Is that right? The performance improvement seems fairly low