Skip to content

feat: opai-codegen#1912 add optional default format for numbers#1913

Closed
matgr1 wants to merge 1 commit into
oapi-codegen:mainfrom
matgr1:feat/add-default-number-format
Closed

feat: opai-codegen#1912 add optional default format for numbers#1913
matgr1 wants to merge 1 commit into
oapi-codegen:mainfrom
matgr1:feat/add-default-number-format

Conversation

@matgr1

@matgr1 matgr1 commented Feb 24, 2025

Copy link
Copy Markdown

adds default-number-format to output options to allow configuring the default format used for type: number (without this, it defaults to 32-bit float)

@matgr1 matgr1 requested a review from a team as a code owner February 24, 2025 19:10
@mromaszewicz

Copy link
Copy Markdown
Member

Thank you for submitting this PR, @matgr1 — but we need to close it because the more general output-options.type-mapping feature delivered via #2223 covers this use case: setting output-options.type-mapping.number.default.type: float64 does what the proposed default-number-format flag would have. The narrower flag wasn't added, but the underlying need is met.

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants