fix: #1905 handle oneOf in nested allOf schemas#1904
Open
matgr1 wants to merge 5 commits into
Open
Conversation
matgr1
marked this pull request as draft
February 14, 2025 18:13
matgr1
force-pushed
the
fix-one-of-nesting
branch
from
February 14, 2025 18:52
18f41f2 to
040c7aa
Compare
matgr1
force-pushed
the
fix-one-of-nesting
branch
from
February 14, 2025 19:02
040c7aa to
eb82ae9
Compare
oneOf in nested allOf schemas
matgr1
marked this pull request as ready for review
February 14, 2025 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main purpose of this PR is to fix the situation where
oneOfgets lost in deeply nestedallOfschemas, for example:{ "allOf": [ { "allOf": [ { "oneOf": [ { "properties": { "a_foo_one_of_0": { "type": "string" } } }, { "properties": { "a_foo_one_of_1": { "type": "string" } } } ] } ] }, { "properties": { "a_foo": { "type": "string" } } } ] }see added comments in
merge_schemas.gofor explanationother fixes/improvements:
anyOfas well asoneOfduring schema mergemergeOpenapiSchemas