Skip to content

fix: Avoid nil reference for gin wrapper#1057

Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom
amweiss:fix-gin-wrapper
Jun 1, 2023
Merged

fix: Avoid nil reference for gin wrapper#1057
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom
amweiss:fix-gin-wrapper

Conversation

@amweiss
Copy link
Copy Markdown
Contributor

@amweiss amweiss commented May 22, 2023

Handle the other required parameter errors like https://github.com/deepmap/oapi-codegen/blame/14548c7e7bbee8d8fbd7e706f9b6f9e3381b44fb/pkg/codegen/templates/gin/gin-wrappers.tmpl#L169.

err will not always be defined as it's in other conditional sections and it's not really needed for these errors.

Also closes #617.

@jamietanna jamietanna added this to the v1.13.0 milestone Jun 1, 2023
@deepmap-marcinr deepmap-marcinr merged commit f442b7b into oapi-codegen:master Jun 1, 2023
@amweiss amweiss deleted the fix-gin-wrapper branch June 1, 2023 16:35
adrianpk pushed a commit to foorester/oapi-codegen that referenced this pull request Jan 16, 2024
adrianpk added a commit to foorester/oapi-codegen that referenced this pull request May 31, 2024
danicc097 pushed a commit to danicc097/oapi-codegen that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template for gin wrappers is incorrectly reporting an 'err' var

3 participants