Fix AdditionalPropertiesType Propagation#1017
Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom May 6, 2023
FragmentedPacket:bugfix-1016-additional-properties-types
Merged
Fix AdditionalPropertiesType Propagation#1017deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom FragmentedPacket:bugfix-1016-additional-properties-types
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom
FragmentedPacket:bugfix-1016-additional-properties-types
Conversation
Contributor
|
I had to revert this, because it broke existing tests of additional properties by duplicating types. |
Contributor
Author
|
I will look further into this. Were these new tests that were added recently? |
Contributor
Author
I just wanted to follow up as I'm not seeing any failing tests and not sure the exact thing that happened, but would like to get this figured out. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…esType key as well. (oapi-codegen#1017)" This reverts commit 0cdf909. Unit tests fail with this change, because some fields in additional properties become duplicated
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
…esType key as well. (oapi-codegen#1017)" This reverts commit 71bd050. Unit tests fail with this change, because some fields in additional properties become duplicated
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…esType key as well. (oapi-codegen#1017)" This reverts commit 71bd050. Unit tests fail with this change, because some fields in additional properties become duplicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016
Updated code to find AdditionalTypes under AdditionalPropertiesType as well. AdditionalPropertiesType is just another Schema object that wasn't being searched before.
I hope this is the proper fix for this as I'm new to Go and this project, but this spot seems to make sense as it's keeping the same structure this library is currently storing additional types, but adds the additional spot when finding AdditionalTypes that isn't currently being searched.