Add InternalServerError when err is not nil in strict-gin#1012
Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom May 5, 2023
Conversation
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a strict server is created with gin, if it returns a non-nil error,
ctx.Errorwill log that error, but it will return HTTP Status 200.Looking at other implementations of echo and http, it seems that the intention is to return a 500 InternalServerError.
In this PR, I would add that HTTP Status should be set to 500 for strict servers in gin.