[47453] Fix limit value in filter not being used when making .all() call#155
Merged
mrashed-dev merged 4 commits intoJun 15, 2021
Conversation
Without this check, if a user does `.filter(limit=x).all()` it will ignore the limit value and just return all.
|
This pull request has been linked to Clubhouse Story #47453: Python SDK document .all() behavior when using limit. |
limit value in filter not being used when making .all() calllimit value in filter not being used when making .all() call
…l-behavior-when-using
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jul 21, 2021
New `nylas` v5.0.0 release bringing in the following additions: * Add support for the Nylas Neural API (#163) * Add `metadata` support (#152) * Add new Room Resource fields (#156) * Add `Nylas-API-Version` header support (#157, #151) as well as the following changes: * Transitioned from `app_id` and `app_secret` naming to `client_id` and `client_secret` (#159, #86) * Fix adding a tracking object to an existing `draft` (#153) * Fix issue when converting offset-aware `datetime` objects to `timestamp` (#154, #143) * Fix `limit` value in filter not being used when making `.all()` call (#155) * Fix `from_` field set by attribute on draft ignored (#162, #160) * Remove `bumpversion` from a required dependency to an extra dependency (#158, #144)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a bug where if the user adds a
limitvalue as a filter before calling.all(), their value will be discarded (e.g.nylas.threads.where(limit=50).all(). Now we properly check if the filter exists and apply the setting before making the request to the API, resulting in the expected behaviour.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.