Skip to content

[Fix] Use default alias in nvm-exec fallback#3852

Open
puneetdixit200 wants to merge 1 commit into
nvm-sh:masterfrom
puneetdixit200:fix-nvm-exec-default-alias
Open

[Fix] Use default alias in nvm-exec fallback#3852
puneetdixit200 wants to merge 1 commit into
nvm-sh:masterfrom
puneetdixit200:fix-nvm-exec-default-alias

Conversation

@puneetdixit200

Copy link
Copy Markdown

Closes #3810

Summary

  • make direct nvm-exec fall back to the default alias when NODE_VERSION and .nvmrc are absent
  • preserve existing .nvmrc handling when a project file is present
  • add fast test coverage with a fake installed default node version

Tests

  • bash -n nvm-exec
  • bash -n "test/fast/Running 'nvm-exec' should display required node version"\n- ./setup && "./Running 'nvm-exec' should display required node version"; code=$?; ./teardown; exit $code from test/fast\n- git diff --check\n- make TEST_SUITE=fast test-bash URCHIN=./node_modules/.bin/urchin was also attempted; the updated nvm-exec test passed, while the broader run failed on existing local-environment-sensitive cases involving color expectations, sudo, missing Linux loader/ldd, /dev/tty, and platform fixture output.

Signed-off-by: puneetdixit200 <puneetdixit4321@email.com>
@slow6r

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvm-exec should use the default alias by default

2 participants