Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates Open VSX extension download URLs to the new Eclipse Content blob host.
Changes:
- Migrates Java Test, Java Debug, and Spring Boot Tools URLs.
- Preserves versioned VSIX paths.
| File | Description |
|---|---|
lua/pkgm/specs/init.lua |
Updates three Open VSX download endpoints. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
@tuxtor Do you mean from this plugin the follow redirect does not work? |
Author
|
@s1n7ax it does for old/legacy version. But it doesn't work for future versions. I believe due to a change on the infra side at openvsx
However the API delivers a different URL
However, using the URL from the API it works and resolves to a different domain So we could either
Hence my proposal is to use the second approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around with the versions parameter in the Open VSX components and noticed newer versions won't work. Open VSX registry changed the blob URLs
For example
curl https://open-vsx.org/api/vscjava/vscode-java-test/0.40.0 |jqReturns
And the api url redirects to a newer blob url
Thus, the switch proposal