Skip to content

Bug/rpc.start does not set path on windows #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1n7ax merged 7 commits into from
Dec 3, 2025
Merged

Bug/rpc.start does not set path on windows #439

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
627f99b
fix: use absolute java path as rpc.start PATH workaround
s1n7ax Dec 3, 2025
ed2b3ba
chore(devcontainer): update nvim-dap dependency
s1n7ax Dec 3, 2025
7a7ba51
fix: windows compatibility fixes
s1n7ax Dec 3, 2025
53e0c10
chore(test): add debug log read on windows
s1n7ax Dec 3, 2025
46aba77
fix: add --force-local flag for windows tar extraction
s1n7ax Dec 3, 2025
4c23644
fix: check tar --force-local support before using
s1n7ax Dec 3, 2025
493d2b6
fix: correct tar command argument order
s1n7ax Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: windows compatibility fixes
  • Loading branch information
@s1n7ax
s1n7ax committed Dec 3, 2025
commit 7a7ba515ee0414c2c8c198fd4fc7ff63230f7e3e
5 changes: 4 additions & 1 deletion lua/pkgm/downloaders/powershell.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
local class = require('java-core.utils.class')
local log = require('java-core.utils.log2')
local err_util = require('java-core.utils.errors')
local path = require('java-core.utils.path')

---@class java-core.PowerShell
---@field url string
Expand All @@ -21,7 +22,9 @@ function PowerShell:_init(opts)

if not opts.dest then
local filename = vim.fs.basename(opts.url)
self.dest = vim.fn.tempname() .. '-' .. filename
local tmp_dir = vim.fn.tempname()
vim.fn.mkdir(tmp_dir, 'p')
self.dest = path.join(tmp_dir, filename)
log.debug('Using temp destination:', self.dest)
else
self.dest = opts.dest
Expand Down
2 changes: 1 addition & 1 deletion lua/pkgm/extractors/tar.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function Tar:extract()
-- Windows: convert backslashes to forward slashes (tar accepts them)
local source = self.source:gsub('\\', '/')
local dest = self.dest:gsub('\\', '/')
cmd = string.format('%s --no-same-owner --force-local -xf "%s" -C "%s"', tar_cmd, source, dest)
cmd = string.format('%s --no-same-owner -xf "%s" -C "%s"', tar_cmd, source, dest)
else
-- Unix: use shellescape
cmd = string.format(
Expand Down
Loading