Refactor YAML handling to improve quoting logic and add support for multiline strings#18298
Merged
Merged
Conversation
cptpiepmatz
requested changes
May 28, 2026
cptpiepmatz
left a comment
Member
There was a problem hiding this comment.
Overall this looks very reasonable
cptpiepmatz
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
to yaml/to ymlto emit YAML that is closer to YAML 1.2 plain-scalar rules while still preserving string semantics when quoting is required.The main change is that string values are no longer quoted by default. Instead, the emitter now only quotes scalars when quoting is necessary for correctness. In addition, multiline strings are emitted as YAML literal block scalars with correct chomping behavior.
User-facing changes (Release notes)
More idiomatic YAML output with smarter string quoting
The previous emitter always quoted string values, which produced valid YAML but was more conservative than necessary and less aligned with YAML 1.2 plain-scalar rules.
This change makes output:
Before:
After:
Multiline strings now emit as:
Additional notes
Examples from #18010 and #16072 were used for testing and creating new tests.