Skip to content

Consolidate version and other metadata in top level Cargo.toml#18286

Merged
cptpiepmatz merged 10 commits into
nushell:mainfrom
Bahex:end-of-fiddly-versioning
May 28, 2026
Merged

Consolidate version and other metadata in top level Cargo.toml#18286
cptpiepmatz merged 10 commits into
nushell:mainfrom
Bahex:end-of-fiddly-versioning

Conversation

@Bahex

@Bahex Bahex commented May 26, 2026

Copy link
Copy Markdown
Member

Description

This should make version bumps easier. And cause smaller diffs.

User-facing changes (Release notes)

N/A

@Bahex Bahex requested a review from cptpiepmatz May 26, 2026 12:11
@sholderbach

sholderbach commented May 26, 2026

Copy link
Copy Markdown
Member

Did you take into account any forked crates we vendored, where license and author information diverges from the standard?

@fdncred

fdncred commented May 26, 2026

Copy link
Copy Markdown
Contributor

I can see how this would work for nushell but what happens for people who want to consume crates individually in their projects? e.g. they only need nuon.

@sholderbach

sholderbach commented May 26, 2026

Copy link
Copy Markdown
Member

With the workspace cargo publish it should populate that into the Cargo.toml on crates.io. (cargo will reformat the original file into a compatible version and keep the original just for reference)

@fdncred

fdncred commented May 26, 2026

Copy link
Copy Markdown
Contributor

With the workspace cargo publish it should populate that into the Cargo.toml on crates.io. (cargo will reformat the original file into a compatible version and keep the original just for reference)

Ah, ok. I didn't realize it worked that way. Thanks!

Bahex
Bahex commented May 26, 2026
View reviewed changes

@Bahex Bahex left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I made some mistakes.

Comment thread crates/nu-glob/Cargo.toml Outdated
Comment thread crates/nu-system/Cargo.toml Outdated
@cptpiepmatz cptpiepmatz force-pushed the end-of-fiddly-versioning branch from abb4b34 to 5f3dca9 Compare May 26, 2026 16:16
@cptpiepmatz

cptpiepmatz commented May 27, 2026

Copy link
Copy Markdown
Member

I'm heavily running a lot of possibilities of combinations and see what features are needed. cargo hacking a lot.

@cptpiepmatz cptpiepmatz marked this pull request as draft May 27, 2026 10:09
@Bahex Bahex force-pushed the end-of-fiddly-versioning branch from 91f52fa to 9a95044 Compare May 27, 2026 12:28
@cptpiepmatz cptpiepmatz added notes:mention Noted in "Hall of Fame" section notes:ready Indicates Ready for Release notes labels May 27, 2026
@cptpiepmatz cptpiepmatz marked this pull request as ready for review May 27, 2026 15:27
@github-actions github-actions Bot added A:parser Issues related to parsing A:plugin-polars Work related to the polars dataframe implementation A:std-library Defining and improving the standard library written in Nu A:LSP Language Server Protocol (nu-lsp) A:plugins This issue is about plugins labels May 27, 2026
@cptpiepmatz cptpiepmatz removed A:parser Issues related to parsing A:plugin-polars Work related to the polars dataframe implementation labels May 27, 2026
@cptpiepmatz cptpiepmatz removed A:std-library Defining and improving the standard library written in Nu A:LSP Language Server Protocol (nu-lsp) A:plugins This issue is about plugins labels May 27, 2026
@cptpiepmatz cptpiepmatz merged commit 1d754e6 into nushell:main May 28, 2026
19 checks passed
@github-actions github-actions Bot added this to the v0.114.0 milestone May 28, 2026
@hustcer hustcer mentioned this pull request May 29, 2026
Merged
@fdncred

fdncred commented May 29, 2026

Copy link
Copy Markdown
Contributor

Ugh, this PR broke the nightlies. Thanks @hustcer for fixing it.

YPares added a commit to YPares/nushellWith that referenced this pull request May 31, 2026
@YPares
update-plugin-list: Updated to account for nushell/nushell#18286
8cbdfbd
YPares added a commit to YPares/nushellWith that referenced this pull request Jun 1, 2026
@YPares
update-plugin-list: Updated to account for nushell/nushell#18286
7b8964d
This was referenced Jun 2, 2026
Closed
Merged
YPares added a commit to YPares/nushellWith that referenced this pull request Jun 9, 2026
@YPares
update-plugin-list: Updated to account for nushell/nushell#18286
da54217
@Bahex Bahex deleted the end-of-fiddly-versioning branch June 10, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cptpiepmatz cptpiepmatz cptpiepmatz approved these changes

Assignees

No one assigned

Labels

notes:mention Noted in "Hall of Fame" section notes:ready Indicates Ready for Release notes

Projects

None yet

Milestone

v0.114.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Bahex @sholderbach @fdncred @cptpiepmatz