Fix flatten silently dropping data when conflicting column appears after flattened column#17816
Open
tauanbinato wants to merge 1 commit intonushell:mainfrom
Conversation
…after flattened column
Member
|
The impl looks reasonable, can you look into what is failing in CI here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flattensilently dropped data when the parent record had a conflicting column name that appeared after the column being flattenedHashSetbefore the loop, so conflict detection works regardless of column orderBefore
After
Release notes summary
Fixed a bug where
flattenwould silently drop data when a nested record/table had column names conflicting with parent columns that appeared later in the record. Conflicting columns are now correctly renamed regardless of column order.Closes #13271