Skip to content

fishgen: Fix flag descriptions showing up as command descriptions #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kissaki wants to merge 3 commits into from
Closed

fishgen: Fix flag descriptions showing up as command descriptions #1120

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e6891
fishgen: Fix flags crossing subcommands
Kissaki May 11, 2025
9bcae16
Fix conflicting flag column names
Kissaki May 11, 2025
193574d
Fix flag descriptions showing up as command descriptions
Kissaki May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix flag descriptions showing up as command descriptions
  • Loading branch information
@Kissaki
Kissaki committed May 11, 2025
commit 193574d32845b4b079ab56e2dd5fd6c3815168bd
10 changes: 8 additions & 2 deletions needs-update/custom-completions/auto-generate/parse-fish.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,17 @@ def make-subcommands-completion [parents: list<string>] {

$fishes
| group-by arguments # group by sub command (arguments flag)
| transpose name args # turn it into a table of name to arguments
| transpose name args # turn it into a table of name to arguments
| each {|subcommand|
[
# description
(if ('description' in ($subcommand.args | columns)) and ($subcommand.args.description != "") { $"# ($subcommand.args.description.0)\n" })
(
if (('description' in ($subcommand.args | columns))
and ($subcommand.args.description != "")
and ('condition' in ($subcommand.args | columns))
and ($subcommand.args.condition == "__fish_use_subcommand")
) { $"# ($subcommand.args.description)\n" }
)
# extern name
$'extern "($parents | append $subcommand.name | str join " " | str trim)"'
# params
Expand Down