Repository navigation
Issue4954 equal to date time - #4957
Conversation
This matches the behaviour of EquatablesConstraint which tries both: x.IEquatable<y> and y.IEquatable<x>
OsirisTerje
left a comment
There was a problem hiding this comment.
Looks good to me, and all tests are passing, and it seems they are covering the code in question.
But I wonder if we should split up the tests, the EqualConstraintTests are now 1500 lines long. I was a bit hard to try to find the tests that actually was to be run for this. There are multiple nested classes, and I am not sure we gain anything by that. This is unrelated to this PR though, but something we could consider rectoring.
|
@OsirisTerje I agree with you that that file is too big. In most, but not all cases, it tests the constraint and not what most users use the |
Fixes #4954
This PR also adds a reciproke test to EqualConstraint:
EqualConstraint now tries both x.Equals(y) and y.Equals(x)
This matches the behaviour of EquatablesConstraint which tries both:
x.IEquatable and y.IEquatable