Repository navigation
Move netstandard1.6 build to netstandard1.4 - #2894
Merged
Merged
Conversation
jnm2
commented
Jun 19, 2018
| <group targetFramework="netstandard1.6"> | ||
| <group targetFramework="netstandard1.4"> | ||
| <dependency id="NETStandard.Library" version="1.6.1" /> | ||
| <dependency id="System.Reflection.TypeExtensions" version="4.4.0" exclude="compile" /> |
Contributor
Author
There was a problem hiding this comment.
exclude="compile" means users' test projects won't reference assemblies in the System.Reflection.TypeExtensions package because of the NUnit package.
Contributor
|
I commented on the issue re: the package dependency, to keep the conversation in one place. 🙂 |
rprouse
approved these changes
Jun 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2887. The first commit adds a netstandard1.4 build and the second commit removes the netstandard1.6 build.
Rather than adding back all our previous .NET Standard 1.3 reflection polyfills, the .NET Standard 1.4 build takes a dependency on System.Reflection.TypeExtensions.