Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
np.strings.partition,rpartition, andreplaceaccept object operands for fixed-width unicode input but fail for StringDType input:result_type(StringDType, object)is object, so these calls fall through to the fixed-width code path, which can't build a StringDType output. This PR converts object operands to the input's StringDType first, following the fixed-width path's rules, so StringDType behaves like unicode. For a StringDType with anna_object, a missing value passed as an operand becomes a null and gets the usual StringDType null error.replacerejects object dtype before callingresult_typebut it's still possible to trigger this inreplaceusing StringDType's missing data support, see the tests.Converting values like
Noneto strings is itself questionable:strmethods andnp.charin NumPy 1.26 raiseTypeError. Aligning the two dtypes first means a possible follow-up deprecation can treat both the same way.A Quansight client found the
partitionbug. I don't think this is worth backporting to 2.5.x, since it doesn't apply cleanly.AI Disclosure
I iterated on this with an AI model.