Repository navigation
Conversation
andyfaff
commented
Oct 12, 2026
| test-extending = [ # includes tests that build extensions / f2py | ||
| { include-group = "test-core" }, | ||
| "Cython", | ||
| "meson", |
Member
Author
There was a problem hiding this comment.
meson and ninja are already part of the build dependency group, and by using an include-group it means we only have to change a pin in one place.
andyfaff
marked this pull request as draft
October 12, 2026 12:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
With this PR the build dependency groups don't install ninja when the platform is pyodide. This mirrors the emscripten.yml job that solely uses
cythonandmeson-pythonpackages for build-system:requires.Without this dependency group change the changes in this numpy-release PR won't work.
AI Disclosure
No AI