BUG: raise ValueError when reading into record array with references (#32227) - #32289
Merged
Merged
Conversation
Member
Author
|
Failed test is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32227.
Fixes a bug with
numpy.rec.fromfileandnumpy.rec.fromstringwhere attempting to read into dtypes with references, including object and structured dtypes, would be unsafely accepted and could lead to segfaults. We already guard against this inPyArray_FromFileand related functions:numpy/numpy/_core/src/multiarray/ctors.c
Lines 3659 to 3664 in 73d1419
The test in this PR would lead to a segfault on
main. This bug was reported privately, cc @rgommersAI Disclosure
I used line completion with GitHub copilot. No other AI used.