ENH: Use PyModule_AddObjectRef in _umath_linalg#31976
Open
prathamhole14 wants to merge 1 commit into
Open
Conversation
Member
|
|
Contributor
Author
|
In the PyModule_GetDict's docs it's mentioned: I also noticed Yes, this is not a "mandatory" but since I was auditing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In the PyModule_GetDict's docs it's mentioned:
It is recommended extensions use other PyModule_* and PyObject_* functions rather than directly manipulate a module’s [__dict__].I also noticed
PyDict_SetItemStringcan fail (returns -1) ref , but in the current code the return value was ignored. (Edited)AI Disclosure
Final review with claude, it suggested to change
dictionaryword tomoduleinaddUfuncs