ENH: pixi-packages: use skip-pyc-compilation for tsan-freethreading - #31558
ENH: pixi-packages: use skip-pyc-compilation for tsan-freethreading#31558lucascolley wants to merge 1 commit into
skip-pyc-compilation for tsan-freethreading#31558Conversation
cd9a52a to
312e37a
Compare
|
Hmm, ~30 minutes is still the slowest CI job by a good margin 🫤 |
looks like ubuntu-arm and macOS are faster, perhaps we can merge if we skip ubuntu? |
312e37a to
119f501
Compare
|
let me see if this is any faster with adding |
119f501 to
e2457d9
Compare
|
@ngoldbaum I've got it down to 24 mins, how close is that to acceptable? |
|
Looking at a recent CI run, the three slowest builds were:
So it would be slow, but not the slowest or even the second-slowest. So on that account it's probably OK to go in. Can you explain again what the marginal benefit of having the CI run going is? I've never actually noticed these pixi CI jobs failing because of issues in the pixi setups so I'm not sure how often they'll pick up bugs that other CI jobs would miss. @rgommers you usually have good intuition about this - what do you say about enabling this CI job? |
admittedly, the use of enabling it right now when the number of downstream users of these packages is O(0) (unless @crusaderky has been making industrious use of them?) is negligible. However, in a future where SciPy et al. are using these packages, I think it is significantly preferable that issues hit NumPy CI before they hit downstream. As for what they will pick up that other jobs won't, I suppose it is problems specific to NumPy's interaction with the conda-forge compiler toolchains and these special build variants. Maybe the coverage elsewhere is good enough ™️ but I still feel like this is nice to have before we introduce these packages into SciPy's workspace. |
|
In general, 24 minutes seems fine to enable, and if it becomes a problem we reserve the right to change our minds. It's in the right ball park I'd say for a TSan job. |
|
not blocking here, but python/cpython#152385 is also pretty exciting |
No description provided.