DEP: remove deprecated 'full' and 'economic' modes from numpy.linalg.qr#31387
Open
AshutoshDevpura wants to merge 2 commits into
Open
DEP: remove deprecated 'full' and 'economic' modes from numpy.linalg.qr#31387AshutoshDevpura wants to merge 2 commits into
AshutoshDevpura wants to merge 2 commits into
Conversation
Member
|
Please fill in the AI disclosure from the PR template that you ignored |
Author
|
Updated the PR description with the AI disclosure. Thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes gh-11521 (partial)
The
'full','f','economic', and'e'modes ofnumpy.linalg.qrwere deprecated in NumPy 1.8.0 (2013-04-01). This PR removes them now
that we are at v2.5.0.dev0.
Changes:
DeprecationWarningbranches for'full'/'f'and'economic'/'e'ValueErrorfor these modes insteadmode == 'economic'return branchimport warningstest_deprecations.pyto expectValueErrorinstead ofDeprecationWarningdoc/release/upcoming_changes/First time committer introduction
Hi! I'm Ashutosh, a Data Scientist working on ML systems (XGBoost, LSTM)
for credit risk modeling. I contribute to open source ML libraries in my
spare time.
AI Disclosure
I used Claude (AI assistant) to help navigate the codebase and understand
where the deprecated code lived. The actual changes, removing the warning
branches, updating the docstring, fixing the tests, and adding the release
note were performed/reviewed and understood by me before submitting.