Repository navigation
Conversation
Member
|
CI is failing |
Member
|
Closing, the PR seems abandoned. @shch4747 let us know if you wish to pick this up again, but please verify docs build locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This pull request is connected to #18020. The pre-existing docstring for np.polydiv showed only one example. This adds two more:
is a zero quotient with the dividend returned as remainder.
which makes the mathematical meaning of the output clear.
First time committer introduction
Second-Year MnC at IIT Delhi student. I use numpy for assigments and here-and-there ML work. I was looking for meaningful open-source contributions to make, came across #18020 but it had been quietly fixed. But noticed that the related docstring could be more comprehensive.
AI Disclosure
I used Claude (Anthropic) to help me navigate the codebase and understand the issue, but I wrote this PR description myself, verified the examples manually in a Python shell, and understand the change fully.