BUG: fix nanmax/nanmin initial argument misbehaving in slow path#31102
Open
joshuaswanson wants to merge 1 commit intonumpy:mainfrom
Open
BUG: fix nanmax/nanmin initial argument misbehaving in slow path#31102joshuaswanson wants to merge 1 commit intonumpy:mainfrom
joshuaswanson wants to merge 1 commit intonumpy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31087.
nanmin/nanmaxmisbehave with theinitialargument in the slow path (non-ndarray input like lists). Two issues:nanmax([1.0], initial=nan)returnsnanbecause the slow path usesnp.amaxwhich propagates NaN frominitial, unlikenp.fmax.reduceused in the fast path. Fixed by stripping NaNinitialbefore passing toamax/amin, sincenanmax/nanminshould ignore NaN ininitialthe same way they ignore NaN in array elements.nanmax([], initial=1.0)returnsnanbecause the all-NaN check (np.all(mask)) returnsTrueon an empty mask and unconditionally overwrites the result with NaN. Fixed by usinginitialas the result for all-NaN slices when it's a valid (non-NaN) value.