Skip to content

ENH: Test ._is_numeric not .char in np.testing.assert_equal #30879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seberg merged 2 commits into from
Mar 6, 2026
Merged

ENH: Test ._is_numeric not .char in np.testing.assert_equal #30879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e83669
ENH: Test .kind not .char in np.testing.assert_equal
hawkinsp Feb 25, 2026
f544e32
Apply suggestion from @seberg
seberg Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion numpy/testing/_private/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ def assert_array_compare(comparison, x, y, err_msg='', verbose=True, header='',
ox, oy = x, y

def isnumber(x):
return x.dtype.char in '?bhilqpBHILQPefdgFDG'
return x.dtype.kind in 'biufc'
Comment thread
seberg marked this conversation as resolved.
Outdated

def istime(x):
return x.dtype.char in "Mm"
Expand Down
Loading