Skip to content

TYP: bincount shape-typing #30536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 1 commit into from
Dec 28, 2025
Merged

TYP: bincount shape-typing #30536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TYP: bincount shape-typing
  • Loading branch information
@jorenham
jorenham committed Dec 28, 2025
commit b4f22cf00138640baaa60fa127a2a50059c48152
15 changes: 8 additions & 7 deletions numpy/_core/multiarray.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ type _ArangeScalar = np.integer | np.floating | np.datetime64 | np.timedelta64
type _ToDates = dt.date | _NestedSequence[dt.date]
type _ToDeltas = dt.timedelta | _NestedSequence[dt.timedelta]

type _BitOrder = L["big", "little"]
type _MaxWork = L[-1, 0]

@type_check_only
class _SupportsArray[ArrayT_co: np.ndarray](Protocol):
def __array__(self, /) -> ArrayT_co: ...
Expand Down Expand Up @@ -619,15 +622,15 @@ def vdot(a: _ArrayLikeObject_co, b: object, /) -> Any: ...
@overload
def vdot(a: object, b: _ArrayLikeObject_co, /) -> Any: ...

def bincount(x: ArrayLike, /, weights: ArrayLike | None = None, minlength: SupportsIndex = 0) -> NDArray[intp]: ...
#
def bincount(x: ArrayLike, /, weights: ArrayLike | None = None, minlength: SupportsIndex = 0) -> _Array1D[intp]: ...

#
def copyto(dst: ndarray, src: ArrayLike, casting: _CastingKind = "same_kind", where: object = True) -> None: ...
def putmask(a: ndarray, /, mask: _ArrayLikeBool_co, values: ArrayLike) -> None: ...

type _BitOrder = L["big", "little"]

@overload
def packbits(a: _ArrayLikeInt_co, /, axis: None = None, bitorder: _BitOrder = "big") -> ndarray[tuple[int], dtype[uint8]]: ...
def packbits(a: _ArrayLikeInt_co, /, axis: None = None, bitorder: _BitOrder = "big") -> _Array1D[uint8]: ...
@overload
def packbits(a: _ArrayLikeInt_co, /, axis: SupportsIndex, bitorder: _BitOrder = "big") -> NDArray[uint8]: ...

Expand All @@ -638,7 +641,7 @@ def unpackbits(
axis: None = None,
count: SupportsIndex | None = None,
bitorder: _BitOrder = "big",
) -> ndarray[tuple[int], dtype[uint8]]: ...
) -> _Array1D[uint8]: ...
@overload
def unpackbits(
a: _ArrayLike[uint8],
Expand All @@ -648,8 +651,6 @@ def unpackbits(
bitorder: _BitOrder = "big",
) -> NDArray[uint8]: ...

type _MaxWork = L[-1, 0]

# any two python objects will be accepted, not just `ndarray`s
def shares_memory(a: object, b: object, /, max_work: _MaxWork = -1) -> bool: ...
def may_share_memory(a: object, b: object, /, max_work: _MaxWork = 0) -> bool: ...
Expand Down
2 changes: 1 addition & 1 deletion numpy/typing/tests/data/reveal/multiarray.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ assert_type(np.vdot(AR_LIKE_f, AR_i8), np.floating)
assert_type(np.vdot(AR_u1, 1), np.signedinteger)
assert_type(np.vdot(1.5j, 1), np.complexfloating)

assert_type(np.bincount(AR_i8), npt.NDArray[np.intp])
assert_type(np.bincount(AR_i8), np.ndarray[tuple[int], np.dtype[np.intp]])

assert_type(np.copyto(AR_f8, [1., 1.5, 1.6]), None)

Expand Down