Repository navigation
DOC: remove hack to override _add_newdocs_scalars - #26826
Merged
Merged
Conversation
…ions][skip cirrus]
Member
Author
|
As far as I can tell the scalars documentation from this PR and from the devdocs are the same. @melissawm am I missing something? |
Member
Author
|
Comparing the HTML, there is an additional |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 2, 2024
charris
added a commit
that referenced
this pull request
Jul 2, 2024
DOC: remove hack to override _add_newdocs_scalars (#26826)
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26820, replaces #26825
Something has changed in the way autoclasses adds all the members. The function
replace_scalar_type_namesis still needed, but locally removing_add_newdocs_scalarsis not. If I totally removereplace_scalar_type_names, documentation is built with full class methods forfloat16, but not so if the function is in place.