Skip to content

fix(cli): filter streamed tool-call markup#761

Merged
DonPrus merged 2 commits intonullclaw:mainfrom
vernonstinebaker:fix/cli-tool-call-stream-filter
Apr 10, 2026
Merged

fix(cli): filter streamed tool-call markup#761
DonPrus merged 2 commits intonullclaw:mainfrom
vernonstinebaker:fix/cli-tool-call-stream-filter

Conversation

@vernonstinebaker
Copy link
Copy Markdown
Contributor

Summary

  • wrap nullclaw agent CLI streaming output with the existing streaming.TagFilter so raw <tool_call>...</tool_call> blocks do not leak into foreground terminal output
  • add a regression test covering streamed tool-call suppression in src/agent/cli.zig
  • retain and free MCP stdio child environment maps in src/mcp.zig to fix the repository-wide leak surfaced by zig build test --summary all

Why

  • streamed provider deltas in the CLI path were written directly to stdout, unlike daemon/channel streaming paths that already strip tool-control markup
  • the full local validation required by AGENTS.md exposed an unrelated MCP env leak in the test suite, so this PR includes the minimal ownership fix needed to keep the suite green

Validation

  • zig build
  • zig build -Doptimize=ReleaseSmall
  • zig build test --summary all

Notes

  • this change is focused to the CLI streaming presentation path; tool execution behavior is unchanged
  • unrelated untracked workspace files were left untouched

@vernonstinebaker vernonstinebaker force-pushed the fix/cli-tool-call-stream-filter branch from 3d6c689 to b97ec9a Compare April 5, 2026 13:47
@DonPrus DonPrus merged commit 1b387b0 into nullclaw:main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants