Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

make tests always use right node + npm#9982

Closed
iarna wants to merge 3 commits intomasterfrom
iarna/make-tests-always-use-right-npm
Closed

make tests always use right node + npm#9982
iarna wants to merge 3 commits intomasterfrom
iarna/make-tests-always-use-right-npm

Conversation

@iarna
Copy link
Copy Markdown
Contributor

@iarna iarna commented Oct 15, 2015

Our test lifecycles regularly run npm commands as a part of them– this patch ensures that they're run with the same npm and node that the original was run.

@iarna iarna force-pushed the iarna/make-tests-always-use-right-npm branch from 7400f8b to 0c5086f Compare October 15, 2015 18:45
@iarna iarna force-pushed the iarna/make-tests-always-use-right-npm branch from 0c5086f to 32d46f1 Compare October 15, 2015 20:53
@iarna iarna added this to the next-next-3 milestone Oct 15, 2015
@othiym23
Copy link
Copy Markdown
Contributor

Reviewed in person: 🐑

iarna added a commit that referenced this pull request Oct 22, 2015
iarna added a commit that referenced this pull request Oct 22, 2015
iarna added a commit that referenced this pull request Oct 22, 2015
@iarna
Copy link
Copy Markdown
Contributor Author

iarna commented Oct 23, 2015

This landed in 3.3.10.

@iarna iarna closed this Oct 23, 2015
@iarna iarna removed the in-progress label Oct 23, 2015
@iarna iarna deleted the iarna/make-tests-always-use-right-npm branch October 28, 2015 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants