Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

deps: remove unused foo.js & bar.js from lru-cache#8214

Closed
Fishrock123 wants to merge 1 commit intonpm:masterfrom
Fishrock123:deps-lru-cache
Closed

deps: remove unused foo.js & bar.js from lru-cache#8214
Fishrock123 wants to merge 1 commit intonpm:masterfrom
Fishrock123:deps-lru-cache

Conversation

@Fishrock123
Copy link
Copy Markdown
Contributor

These files are not found in https://github.com/isaacs/node-lru-cache and appear to have been erroneously committed in 530a2e3.

(see also: nodejs/node#1658 (comment))

@othiym23
Copy link
Copy Markdown
Contributor

Since it doesn't hurt anything, I rebased this and landed it as 79f8a96. I'll reiterate, though, that the way the npm team deals with bundled dependencies is just to run npm i -S 'package@~version' and then checking in the results (as long as the tests continue to pass). Trimming or curating those installs is a pointless use of the team's time, and if you have issues with the stuff that gets checked in as a result, the issues are better taken up with the upstream packagers.

@othiym23 othiym23 closed this May 15, 2015
@Fishrock123
Copy link
Copy Markdown
Contributor Author

Right, but these aren't included in that repo, and the tests/etc don't seem to produce them?

@Fishrock123 Fishrock123 deleted the deps-lru-cache branch May 15, 2015 01:14
@othiym23
Copy link
Copy Markdown
Contributor

They're in the package as it was published to the registry, hence my suggestion to take it up with the packager (which, in this case, is @isaacs). As much as possible, to keep things moving along, we need to be able to treat node_modules as a black box, in much the same way that I expect the downstreams (Node.js and io.js) to treat deps/npm as a black box. It really isn't a productive use of my time to clean up insignificant cruft like this.

@Fishrock123
Copy link
Copy Markdown
Contributor Author

They're in the package as it was published to the registry

Ohhhh, right, I didn't check that. Yes, I agree it does not matter in that case, messy or not.

Pssst, ya'll should consider using the files: package.json thing for all npm-managed modules. ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants