Conversation
Deleting uri properties will not work anymore in io.js 2.0.0 as the properties are now getters/setters and deleting them will delete the getters/setters themselves from the instance. Nulling the properties has the same effect, while also bringing a performance gain over delete. Related: nodejs/node#1591
c410888 to
a43a152
Compare
|
Thanks for putting this together, @silverwind. This change appears to cause some breakage elsewhere in npm (perhaps I'll keep digging and see if I can figure out what's going on. |
|
Interesting. That means setting |
|
0.8 does behave the same; looking at the Travis CI, the failure is from a timeout in the |
|
@silverwind I think the problem may actually be on my laptop, because every since I first pulled that branch, I haven't been able to get the tests to pass, regardless of what branch of npm I've got checked out. So I think it's safe to say this isn't your problem. I'll dig into this a little more tomorrow. @dougwilson There's something up with tap under 0.8. I've been poking at it for about a month now, but haven't had the time to chase it to ground. There are intermittent spurious failures throughout the test suite under 0.8, so unless that particular error is repeatable for one of us, I wouldn't worry about it. |
|
Sorry to reverse course here, but after lengthy discussion with @isaacs about not just this change but the larger changes to
Thanks for putting this together, though! I appreciate the quick turnaround on sending us a patch along with filing the issue! |
Deleting a uri's properties will not work anymore in io.js 2.0.0 as the properties are now getters/setters and deleting them will delete the getters/setters themselves from the instance. Nulling the properties has the same effect, while also bringing a performance gain over
delete.Related: nodejs/node#1591