Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

node-gyp@3.6.2#20276

Closed
zkat wants to merge 3 commits intorelease-nextfrom
zkat/add-ng-back-in
Closed

node-gyp@3.6.2#20276
zkat wants to merge 3 commits intorelease-nextfrom
zkat/add-ng-back-in

Conversation

@zkat
Copy link
Copy Markdown
Contributor

@zkat zkat commented Apr 6, 2018 •
edited
Loading

Fixes: #20163

This PR also adds a test to make doubleplus sure we don't accidentally move around node-g again and that the version that npm-lifecycle uses matches the one we use in the toplevel, so we don't get any accidental inconsistencies even if they happen to end up duplicated (it doesn't need to be a singleton)

@zkat zkat requested a review from a team as a code owner April 6, 2018 15:25
@zkat zkat mentioned this pull request Apr 6, 2018
Closed
@zkat zkat force-pushed the zkat/add-ng-back-in branch from 3d310ce to ea4e814 Compare April 6, 2018 15:44
@MylesBorins MylesBorins mentioned this pull request Apr 6, 2018
Closed
@mapsam mapsam mentioned this pull request Apr 9, 2018
Open
iarna pushed a commit that referenced this pull request Apr 9, 2018
@zkat @iarna
test: use classic reporter on travis again
9218c03 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 9, 2018
@zkat @iarna
node-gyp@3.6.2
45a821d 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 9, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
0bc2cd4 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
@mapsam mapsam mentioned this pull request Apr 9, 2018
Closed
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: use classic reporter on travis again
c702d04 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
node-gyp@3.6.2
3770e15 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
425b137 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: use classic reporter on travis again
24c9b41 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
node-gyp@3.6.2
a610007 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
7493ed7 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: use classic reporter on travis again
ec8dd2b 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
node-gyp@3.6.2
2f4919e 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
3938c41 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: use classic reporter on travis again
a45df53 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
node-gyp@3.6.2
cfe562c 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
457b9e5 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: use classic reporter on travis again
edc1621 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
node-gyp@3.6.2
33f6a6b 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
e6e19b8 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
@MylesBorins
Copy link
Copy Markdown

MylesBorins commented Apr 11, 2018

@zkat @iarna is there a timeline on this landing? I'd like to float this in nodejs/node#19840 and try and get it pulled into the next 8.x RC which is currently being prepped.

@zkat
Copy link
Copy Markdown
Contributor Author

zkat commented Apr 11, 2018

@MylesBorins Rebecca's working on the release right now. So, "soon".

iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: use classic reporter on travis again
58a2822 
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
node-gyp@3.6.2
d2b20d3 
Fixes: #20163
Credit: @zkat
PR-URL: #20276
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
test: verify that node-gyp stuff is correct
e8f4fac 
PR-URL: #20276
Credit: @zkat
Reviewed-By: @iarna
@iarna iarna force-pushed the release-next branch 3 times, most recently from 2e76172 to fe31e66 Compare April 13, 2018 20:20
@zkat
Copy link
Copy Markdown
Contributor Author

zkat commented Apr 18, 2018

This was already merged, so closing it.

@zkat zkat closed this Apr 18, 2018
@zkat zkat deleted the zkat/add-ng-back-in branch April 18, 2018 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@iarna iarna iarna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zkat @MylesBorins @iarna