This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Closed
Conversation
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Oct 27, 2017
MylesBorins
added a commit
to nodejs/node
that referenced
this pull request
Oct 30, 2017
refs: npm/npm#18964 PR-URL: #16509 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 30, 2017
refs: npm/npm#18964 PR-URL: #16509 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Also, the error message should say "to a newer version of npm". Maybe you can just sneak this in here? Update: Sorry my bad. In many cases, the error message is right. It's still wrong in this case though, but that should never happen in the first place. |
|
you'll need to update the ci configs too... |
* remove 7 * add 9
Author
|
@depoulo this patch should fix the exact problem @graingert I've re targeted this to canary so no need to worry about the zlib I've updated the travis yaml in another commit so you might be able to close #19025 |
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
refs: npm/npm#18964 PR-URL: nodejs/node#16509 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
refs: npm/npm#18964 PR-URL: nodejs/node#16509 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Does anyone have any idea what the ETA is for an npm 5.5.2 with support for node 9? |
c8bbdbf to
dc64380
Compare
Author
|
this is fixed by 6caf230 |
|
Hurrah! 🎆 🎉 and thanks! |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
refs: npm/npm#18964 PR-URL: nodejs/node#16509 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like something that needs to be done 😄