Conversation
|
Could I possibly be a collaborator to take care the low priority issues btw? That can be a big motivation to me :) |
Fixed the quote_cmd issue. Fixed the error related to inexisted `copyNodeLib`. Removed `.patch` files. Credit: @bnoordhuis Credit: @vsemozhetbyt Credit: @kunalspathak Credit: @richardlau Credit: @refack Credit: @pmed Credit: @lc-soft
|
@watilde If you want to participate more, head on over to https://package.community/ You can help us figure out how we assign that kind of thing! (All changes go through PR even if you are a collab so it's not particularly different. Merging is currently really a function of the release process so it's kind of. ¯_(ツ)_/¯) |
iarna
left a comment
There was a problem hiding this comment.
Hey, if you can just remove the commit that changes our test matrix I think this is fine.
There was a problem hiding this comment.
We can't drop 0.12 or 0.10. Dropping support is a breaking change and 2.x can't take breaking changes.
There was a problem hiding this comment.
It looks like test failures are coming from a transitive dependency of npm-registry-couchapp, I'm prepared to give them a pass for the time being to get this out the door.
There was a problem hiding this comment.
I just opened PR to npm-registry-couchapp to fix this: npm/npm-registry-couchapp#273
|
Thx for the review comments. I've reverted the last commit that removed |
Let's push nodejs/node#12479 forward. Once npm@2 is bumped, I also can take care to make a new PR to push this to node@4.