Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

node-gyp@3.6.1#16484

Closed
addaleax wants to merge 1 commit intonpm:latestfrom
addaleax:node-gyp-3.6.1
Closed

node-gyp@3.6.1#16484
addaleax wants to merge 1 commit intonpm:latestfrom
addaleax:node-gyp-3.6.1

Conversation

@addaleax
Copy link
Copy Markdown
Contributor

Basically ran npm i -S node-gyp@3.6.1, seems to have worked out well.

@isaacs isaacs added the review label Apr 30, 2017
@zkat zkat removed the review label Apr 30, 2017
@zkat zkat added this to the next-next milestone Apr 30, 2017
@zkat
Copy link
Copy Markdown
Contributor

zkat commented Apr 30, 2017

@addaleax Thanks! This is a release week, so we'll pull this in and send up a PR probably ~friday

@addaleax
Copy link
Copy Markdown
Contributor Author

Cool! That isn’t npm@5 by any chance, is it? I hear it’s fast.

Copy link
Copy Markdown
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zkat
Copy link
Copy Markdown
Contributor

zkat commented Apr 30, 2017

@addaleax we have a regular npm@4 release on top of the public beta for npm5. I hear it's fast too but it's probably all marketing bullshit tbh. Can't trust these corporate types imo.

New node-gyp should go into both :)

@zkat
Copy link
Copy Markdown
Contributor

zkat commented May 27, 2017

This has been included in npm@5.0.0. Closing

@zkat zkat closed this May 27, 2017
@addaleax addaleax deleted the node-gyp-3.6.1 branch May 27, 2017 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants