This repository was archived by the owner on Aug 11, 2022. It is now read-only.
test: don't use undocumented res.writeHeader alias#15874
Merged
zkat merged 1 commit intonpm:release-nextfrom Mar 8, 2017
Merged
test: don't use undocumented res.writeHeader alias#15874zkat merged 1 commit intonpm:release-nextfrom
zkat merged 1 commit intonpm:release-nextfrom
Conversation
res.writeHeader is an undocumented alias to res.writeHead It's docs-deprecated in nodejs/node#11355
zkat
approved these changes
Mar 7, 2017
zkat
pushed a commit
that referenced
this pull request
Mar 9, 2017
res.writeHeader is an undocumented alias to res.writeHead It's docs-deprecated in nodejs/node#11355 PR-URL: #15874 Credit: @ChALkeR Reviewed-By: @zkat
zkat
pushed a commit
that referenced
this pull request
Mar 10, 2017
res.writeHeader is an undocumented alias to res.writeHead It's docs-deprecated in nodejs/node#11355 PR-URL: #15874 Credit: @ChALkeR Reviewed-By: @zkat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.writeHeaderis an undocumented alias tores.writeHeadIt's docs-deprecated in nodejs/node#11355
Refs: nodejs/node#11355
Note: I haven't run tests locally and judging by the folder this resides in I am not sure if this is covered on CI.
CI build failure is due to a broken Slack integration: