This repository was archived by the owner on Aug 11, 2022. It is now read-only.
test: Fix progress config testing to ignore local user configs#12329
Closed
test: Fix progress config testing to ignore local user configs#12329
Conversation
Previously, _any_ local setting would cause the tests to fail as they were trying to test what the default values for the progress bar would be in different environments and any explicit setting overrides those defaults.
Contributor
Author
|
This has historically only shown up when node contributors have tried to run the npm tests w/ local configs. For instance, nodejs/node#6153 (comment) |
Contributor
Author
|
Merged into v3.8.8! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any local setting would cause the tests to fail as
they were trying to test what the default values for the progress
bar would be in different environments and any explicit setting
overrides those defaults.