This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Fix #10974 - deprecate works on all version by default#12079
Closed
polm wants to merge 1 commit intonpm:masterfrom
Closed
Fix #10974 - deprecate works on all version by default#12079polm wants to merge 1 commit intonpm:masterfrom
polm wants to merge 1 commit intonpm:masterfrom
Conversation
When a semver spec is not supplied, npa supplies a default spec of 'latest'. This is usually correct, but for deprecation the default has been to apply to all versions of a package. This patch just checks the raw spec and if it's empty it overrides with with the '*' version range, which is what people in the issue discussion were doing anyway. This includes a working test. -POLM
Contributor
|
LGTM! 🎉 Thanks for the patch! |
zkat
pushed a commit
that referenced
this pull request
Mar 31, 2016
When a semver spec is not supplied, npa supplies a default spec of 'latest'. This is usually correct, but for deprecation the default has been to apply to all versions of a package. This patch just checks the raw spec and if it's empty it overrides with with the '*' version range, which is what people in the issue discussion were doing anyway. Fixes: #10974 PR-URL: #12079 Credit: @polm Reviewed-By: @zkat
zkat
pushed a commit
that referenced
this pull request
Mar 31, 2016
When a semver spec is not supplied, npm supplies a default spec of `latest`. This is usually correct, but for deprecation the default has been to apply to all versions of a package. This patch just checks the raw spec and if it's empty it overrides with with the `*` version range, which is what people in the issue discussion were doing anyway. Fixes: #10974 PR-URL: #12079 Credit: @polm Reviewed-By: @zkat
Contributor
|
This fix was included with |
michaelnisi
pushed a commit
to michaelnisi/npm
that referenced
this pull request
Apr 2, 2016
When a semver spec is not supplied, npa supplies a default spec of 'latest'. This is usually correct, but for deprecation the default has been to apply to all versions of a package. This patch just checks the raw spec and if it's empty it overrides with with the '*' version range, which is what people in the issue discussion were doing anyway. Fixes: npm#10974 PR-URL: npm#12079 Credit: @polm Reviewed-By: @zkat
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a semver spec is not supplied, npa supplies a default spec of
'latest'. This is usually correct, but for deprecation the default has
been to apply to all versions of a package.
This patch just checks the raw spec and if it's empty it overrides with
with the '*' version range, which is what people in the issue discussion
were doing anyway.
This includes a working test. -POLM