This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Closed
Conversation
6cb369b to
4238ea9
Compare
4238ea9 to
3b39093
Compare
Contributor
Author
|
@kat |
5a8614d to
30ec99b
Compare
decddf7 to
be2f831
Compare
224a2ba to
8b73be8
Compare
0626f34 to
d10a590
Compare
This was referenced Feb 15, 2016
54441b4 to
bbd45f1
Compare
Contributor
Author
|
💥 🐑 👾 |
* removed legacy-env-reader test * test that regular env vars are passed down * test that npm-prefixed vars are stripped * test that package.json configs are added to env * test that package.json configs are prefixed with npm_package and added to the env
5ae1b60 to
0870ecd
Compare
Contributor
|
This needs to be rebased on 2.x before merging it there, and it'll take a bit to make sure everything is passing properly over in LTS. I'll make a separate PR for that. :) |
iarna
added a commit
that referenced
this pull request
Feb 18, 2016
iarna
added a commit
that referenced
this pull request
Feb 18, 2016
iarna
pushed a commit
that referenced
this pull request
Feb 18, 2016
* removed legacy-env-reader test * test that regular env vars are passed down * test that npm-prefixed vars are stripped * test that package.json configs are added to env * test that package.json configs are prefixed with npm_package and added to the env Credit: @zkat PR-URL: #11292 Reviewed-By: @iarna
Contributor
|
This was merged and included in |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The great legacy test rewrite. All of the things in
test/packageshave been mechanically converted into stand alone tap tests intest/tap/legacy-*.js. Remaining work to be done is:Port tests to tap:
@zkat will do these:
@iarna will do these:
See 4238ea9 for an example of what these ports look like.
When one of us is done with our list above we'll check back in and probably move on to the following two (or split up the remaining legacy tests above, depending on progress).
We also need to write tests that:
npm packis able to install itself.