Include query string in cache key#38
Closed
jpb wants to merge 1 commit intonpm:latestfrom
unbounce:cache-key-query-string
Closed
Include query string in cache key#38jpb wants to merge 1 commit intonpm:latestfrom unbounce:cache-key-query-string
jpb wants to merge 1 commit intonpm:latestfrom
unbounce:cache-key-query-string
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the URL's query string in the cache key. Not including the query component in the cache key can result in an ineffective cache or subtle bugs. The cache key for URLs that do not have a query component have not changed.
RFC 7234 states that "the primary cache key consists of the request method and target URI", the query component being part of this.
Fixes #7