Add a condition to fix third-party registries returning E400#5480
Merged
lukekarrys merged 2 commits intonpm:latestfrom Sep 21, 2022
Merged
Add a condition to fix third-party registries returning E400#5480lukekarrys merged 2 commits intonpm:latestfrom
lukekarrys merged 2 commits intonpm:latestfrom
Conversation
wraithgar
reviewed
Sep 8, 2022
3037d35 to
f3b0c43
Compare
lukekarrys
approved these changes
Sep 21, 2022
This was referenced Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for third party registries which return E400 on /-/npm/v1/keys instead of E404.
This will make the behavior consistent for these repositories and other third party registries which return 400.
References
Fixes #5479