Skip to content

feat: remove npm birthday#5455

Merged
wraithgar merged 1 commit intolatestfrom
gar/birthday
Sep 8, 2022
Merged

feat: remove npm birthday#5455
wraithgar merged 1 commit intolatestfrom
gar/birthday

Conversation

@wraithgar
Copy link
Copy Markdown
Member

@wraithgar wraithgar commented Sep 1, 2022 •
edited
Loading

BREAKING CHANGE: this removes the npm birthday command

Closes npm/statusboard#450

@wraithgar wraithgar requested a review from a team as a code owner September 1, 2022 14:29
@npm-cli-bot
Copy link
Copy Markdown
Collaborator

npm-cli-bot commented Sep 1, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.710 ±1.90 17.600 ±0.84 15.492 ±0.17 18.921 ±2.90 2.969 ±0.23 2.792 ±0.07 2.313 ±0.05 10.440 ±0.34 2.105 ±0.01 4.063 ±0.87
#5455 46.433 ±4.65 18.216 ±0.25 15.774 ±0.17 17.896 ±0.25 2.758 ±0.01 2.717 ±0.05 2.165 ±0.06 10.601 ±0.34 2.094 ±0.00 3.171 ±0.06
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 31.932 ±5.71 13.962 ±0.24 11.742 ±0.16 12.766 ±0.40 2.565 ±0.04 2.493 ±0.03 2.294 ±0.01 8.234 ±0.08 2.099 ±0.04 2.932 ±0.02
#5455 28.517 ±1.19 13.111 ±0.06 11.298 ±0.19 12.259 ±0.55 2.406 ±0.00 2.518 ±0.13 2.175 ±0.00 7.624 ±0.22 2.129 ±0.01 2.754 ±0.10

@nlf
Copy link
Copy Markdown
Contributor

nlf commented Sep 7, 2022

we should deprecate @npmcli/npm-birthday too

@wraithgar
feat: remove npm birthday
7cf5a0b 
BREAKING CHANGE: this removes the `npm birthday` command
@wraithgar wraithgar merged commit 49bbb2f into latest Sep 8, 2022
@wraithgar wraithgar deleted the gar/birthday branch September 8, 2022 17:01
@github-actions github-actions Bot mentioned this pull request Sep 8, 2022
Merged
@wraithgar
Copy link
Copy Markdown
Member Author

wraithgar commented Sep 8, 2022

we should deprecate @npmcli/npm-birthday too

Done.

This was referenced Sep 10, 2022
Closed
Open
Open
@github-actions github-actions Bot mentioned this pull request Sep 19, 2022
Open
@lukekarrys lukekarrys mentioned this pull request Nov 1, 2022
Closed
This was referenced Nov 5, 2022
Closed
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 16, 2022
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nlf nlf nlf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE(birthday): Remove command

3 participants

@wraithgar @npm-cli-bot @nlf