Skip to content

update npm-registry-fetch (and pacote and npm-profile)#4326

Merged
ruyadorno merged 4 commits intorelease-nextfrom
deps/npm-registry-fetch
Jan 26, 2022
Merged

update npm-registry-fetch (and pacote and npm-profile)#4326
ruyadorno merged 4 commits intorelease-nextfrom
deps/npm-registry-fetch

Conversation

@wraithgar
Copy link
Copy Markdown
Member

@wraithgar wraithgar commented Jan 25, 2022

  • deps: pacote@12.0.3
  • deps: npm-profile@6.0.0
  • deps: npm-registry-fetch@12.0.1

@wraithgar wraithgar requested a review from a team as a code owner January 25, 2022 19:20
@wraithgar wraithgar changed the title deps: npm-registry-fetch update npm-registry-fetch (and pacote and npm-profile) Jan 25, 2022
@npm-robot
Copy link
Copy Markdown
Contributor

npm-robot commented Jan 25, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 49.801 ±0.26 29.218 ±0.18 32.184 ±21.58 19.725 ±0.80 2.852 ±0.01 2.888 ±0.02 2.321 ±0.01 11.574 ±0.46 2.270 ±0.01 3.871 ±0.80
#4326 0.401 ±0.02 0.404 ±0.01 0.390 ±0.00 0.389 ±0.00 0.389 ±0.00 0.385 ±0.00 0.384 ±0.00 0.389 ±0.00 0.390 ±0.00 0.386 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.353 ±0.97 22.488 ±0.09 12.379 ±0.10 13.916 ±0.48 2.521 ±0.01 2.522 ±0.01 2.272 ±0.01 8.287 ±0.08 2.109 ±0.02 3.393 ±0.66
#4326 0.394 ±0.00 0.397 ±0.01 0.387 ±0.00 0.396 ±0.00 0.391 ±0.00 0.408 ±0.02 0.390 ±0.00 0.394 ±0.00 0.390 ±0.00 0.391 ±0.00

@wraithgar wraithgar force-pushed the deps/npm-registry-fetch branch from 3842727 to 9e9a426 Compare January 25, 2022 22:13
ruyadorno
ruyadorno suggested changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just take a look to confirm but it seems to me that these are unwanted deps popping up on arborist, otherwise the rest of updates looks fine 👍

Comment thread workspaces/arborist/package.json Outdated
Comment thread package-lock.json Outdated
@wraithgar wraithgar force-pushed the deps/npm-registry-fetch branch from 9e9a426 to aa50a09 Compare January 26, 2022 14:51
@ruyadorno ruyadorno merged commit 90c384c into release-next Jan 26, 2022
@ruyadorno ruyadorno deleted the deps/npm-registry-fetch branch January 26, 2022 20:51
@wraithgar wraithgar mentioned this pull request Jan 27, 2022
Merged
@npm-robot npm-robot mentioned this pull request Jan 27, 2022
Closed
@JeromeFitz JeromeFitz mentioned this pull request Feb 11, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar @npm-robot @ruyadorno