Repository navigation
Conversation
A host that accepts TCP but never answers the startup handshake stayed in the Unknown state. The read timeout breaks the connector while it is still Connecting, which intentionally skips marking the host offline, and the following Break from Open returns early because the connector is already Broken. Mark the host offline when the final Open attempt fails too, so subsequent connections skip it until Host Recheck Seconds expires, like a host that refuses connections. Fixes npgsql#6733
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host that accepts TCP but never answers the startup handshake stayed in the Unknown state. The read timeout breaks the connector while it is still Connecting, which intentionally skips marking the host offline, and the following Break from Open returns early because the connector is already Broken.
Mark the host offline when the final Open attempt fails too, so subsequent connections skip it until Host Recheck Seconds expires, like a host that refuses connections.
with fix, we can see this in output from issue for both cases (tested on real multihost pg)
Fixes #6733