Use ThrowHelper for inline exception throws in NpgsqlConnection#6589
Open
LindqvistMartin wants to merge 1 commit into
Open
Use ThrowHelper for inline exception throws in NpgsqlConnection#6589LindqvistMartin wants to merge 1 commit into
LindqvistMartin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #2237. Picking up after vonzshik's #4872.
Replaced 7 inline
throw new ...calls inNpgsqlConnection.cswith the existingThrowHelperhelpers. Same exception types and messages, pure mechanical change.Skipped two:
Close:[DoesNotReturn]doesn't satisfy CS0163, so swapping needs an unreachablebreak;after the call. Felt noisier than just leaving the throw.GetSchemauses theArgumentOutOfRangeException(paramName, actualValue, message)ctor, and there's no matching ThrowHelper for that overload today.Easy to widen to other files (NpgsqlCommand etc.) or add the missing helper for that ctor in a follow-up, if useful.