Fix off-by-one in ThrowColumnMismatch exception message#6584
Open
BrunoSync wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6583
Problem
ThrowColumnMismatchwas using_column + 1in the exception message,but
_columnalready holds the correct number of values written when themethod is called from
StartRow. This caused the reported value count toalways be off by one.
For example, with a 3-column table where only 2 values were written:
when it should say:
Fix
Removed the
+ 1from the interpolated string inThrowColumnMismatch.Test
Added
Write_column_out_of_bounds_exception_messagetoCopyTests.csto verify the exception message reports the correct value count.